fix(microservices): cleanup unary call on unsubscribe #10288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
For grpc unary requests, if the consumer unsubscribes from the Observable before the unary response arrives, the call isn't cancelled, as opposed to a streaming endpoint, which does handle client-side unsubscribes. This is a problem in high-performance grpc applications, where we may build timeout/retry logic into demanding endpoints, such as long-running db queries. Retried but not closed upstream calls can lead to unnecessary cpu load, network overhead, etc.
I provided a minimal reproduction example here: https://github.com/szilveszterandras/nest-unary
Issue Number: N/A
What is the new behavior?
If a subscriber unsubscribes from the Observable coming out of a unary request, the grpc call is cancelled.
Does this PR introduce a breaking change?
Other information