Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): stringify arrays on printing with console-logger #10291

Merged
merged 2 commits into from Sep 19, 2022
Merged

fix(common): stringify arrays on printing with console-logger #10291

merged 2 commits into from Sep 19, 2022

Conversation

yukukotani
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #10280

What is the new behavior?

ConsoleLogger prints arrays as json like objects.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 27c54789-b975-4f2c-969f-f8e4bfaffeab

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.817%
Totals Coverage Status
Change from base Build 33d64ea6-8564-4074-89ae-b787d2d45c2d: 0.0%
Covered Lines: 6100
Relevant Lines: 6502
💛 - Coveralls

jmcdo29
jmcdo29 approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the tests and for showing that this is how our Kafka serializer is doing the check too

@yukukotani yukukotani changed the title test(common): stringify arrays on printing with console-logger fix(common): stringify arrays on printing with console-logger Sep 18, 2022
@kamilmysliwiec kamilmysliwiec mentioned this pull request Sep 19, 2022
Closed
15 tasks
@kamilmysliwiec kamilmysliwiec merged commit 3505a00 into nestjs:master Sep 19, 2022
@kamilmysliwiec
Copy link
Member

lgtm

@yukukotani yukukotani deleted the console-logger-stringify-array branch September 19, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony133 Tony133 Tony133 approved these changes

@jmcdo29 jmcdo29 jmcdo29 approved these changes

@thenglong thenglong thenglong approved these changes

Assignees
No one assigned
Labels
scope: common type: bug 😭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yukukotani @coveralls @kamilmysliwiec @Tony133 @jmcdo29 @thenglong