Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common,express,fastify): enhance the type of httpServer #11115

Merged
merged 2 commits into from
Apr 5, 2023
Merged

feat(common,express,fastify): enhance the type of httpServer #11115

merged 2 commits into from
Apr 5, 2023

Conversation

CodyTseng
Copy link
Contributor

@CodyTseng CodyTseng commented Feb 15, 2023 •
edited by kamilmysliwiec
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Feb 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build e7a337f1-3fd6-425e-821d-35d08687506b

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.885%
Totals Coverage Status
Change from base Build 7453df9a-df0b-4869-bbe2-111729beeda7: 0.0%
Covered Lines: 6488
Relevant Lines: 6985
💛 - Coveralls

jmcdo29
jmcdo29 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simylein
Copy link

simylein commented Mar 7, 2023

Can we merge this sometime?

@kamilmysliwiec kamilmysliwiec added this to the 10.0.0 milestone Apr 5, 2023
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 10.0.0 April 5, 2023 11:06
@kamilmysliwiec kamilmysliwiec merged commit 702eebf into nestjs:10.0.0 Apr 5, 2023
@kamilmysliwiec kamilmysliwiec mentioned this pull request Apr 17, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony133 Tony133 Tony133 approved these changes

@jmcdo29 jmcdo29 jmcdo29 approved these changes

Assignees
No one assigned
Labels
scope: platform status: blocked 🚫 type: enhancement 🐺
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CodyTseng @coveralls @simylein @Tony133 @jmcdo29 @kamilmysliwiec