Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): fix @Inject and @Optional return types #11318

Conversation

skrtheboss
Copy link
Contributor

@skrtheboss skrtheboss commented Mar 22, 2023

Use PropertyDecorator and ParameterDecorator as return type to ensure typings are correct

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Mar 22, 2023

Pull Request Test Coverage Report for Build 83b3d2c7-f376-4160-a220-1097d54e8f18

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 25 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 92.655%

Files with Coverage Reduction New Missed Lines %
packages/core/injector/module.ts 25 78.19%
Totals Coverage Status
Change from base Build 355edd54-ae26-4f3b-a472-2834ab2bca98: -0.001%
Covered Lines: 6497
Relevant Lines: 7012

💛 - Coveralls

Use PropertyDecorator and ParameterDecorator as return type to ensure typings are correct
@skrtheboss skrtheboss force-pushed the fix/inject-and-optional-decorator-typings branch from a14bf37 to ffc09ee Compare March 22, 2023 08:08
@kamilmysliwiec kamilmysliwiec added this to the 10.0.0 milestone Apr 5, 2023
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 10.0.0 April 5, 2023 11:06
@kamilmysliwiec kamilmysliwiec merged commit 5aab28f into nestjs:10.0.0 Apr 5, 2023
@skrtheboss skrtheboss deleted the fix/inject-and-optional-decorator-typings branch April 5, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants