Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): update interface deprecated for kafka #11413

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Mar 31, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Proposal:

  • Updated the ConsumerSubscribeTopic interface with ConsumerSubscribeTopics, because ConsumerSubscribeTopic is deprecated.

screenshot-interface-kafka

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4dbdb988-78dd-4fa1-b908-3837b64146d1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 92.886%

Files with Coverage Reduction New Missed Lines %
packages/core/inspector/graph-inspector.ts 1 90.11%
packages/core/inspector/serialized-graph.ts 5 77.61%
packages/core/injector/injector.ts 21 73.72%
packages/core/injector/module.ts 25 78.19%
Totals Coverage Status
Change from base Build f5bc18da-315b-421d-974d-331e8f0b5f71: 0.2%
Covered Lines: 6489
Relevant Lines: 6986

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 10.0.0 milestone Apr 5, 2023
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 10.0.0 April 5, 2023 11:06
@kamilmysliwiec kamilmysliwiec merged commit 03aa13e into nestjs:10.0.0 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants