Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(websockets) need to handle ws unexpected connection error and log it #1144

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

spaiter
Copy link

@spaiter spaiter commented Oct 2, 2018

bugfix(websockets) need to handle ws unexpected connection error and log it

Fixed unhandled ws connection error in ws-adapter

No breaking changes

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[+] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[+] No

Other information

…log it

Fixed unhandled ws connection error in ws-adapter

No breaking changes
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.949% when pulling bf94531 on spaiter:fix-ws-unexpected-close into 65bb7e7 on nestjs:master.

@kamilmysliwiec
Copy link
Member

Thanks!

@kamilmysliwiec kamilmysliwiec merged commit 81fe712 into nestjs:master Oct 5, 2018
@spaiter spaiter deleted the fix-ws-unexpected-close branch October 10, 2018 13:30
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants