Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update repo references in package.json files #11535

Merged
merged 1 commit into from
Apr 21, 2023
Merged

chore: update repo references in package.json files #11535

merged 1 commit into from
Apr 21, 2023

Conversation

CemYil03
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Code style update (formatting, local variables)
  • Other... Please describe: minor change to comply with npmjs docs

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

https://docs.npmjs.com/cli/v9/configuring-npm/package-json#repository

The URL should be a publicly available (perhaps read-only) url that can be handed directly to a VCS program without any modification. It should not be a url to an html project page that you put in your browser. It's for computers.

If the package.json for your package is not in the root directory (for example if it is part of a monorepo) ...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 448efafa-b56e-499e-8a77-2a63f6279c25

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.675%

Totals Coverage Status
Change from base Build 4d97af2b-5b7e-488e-a334-ead2f9bfc8a8: 0.0%
Covered Lines: 6516
Relevant Lines: 7031

💛 - Coveralls

Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now npm docs @nestjs/core should redirect us to the right path inside the repo. Thanks!

@kamilmysliwiec kamilmysliwiec merged commit 55aa3f3 into nestjs:master Apr 21, 2023
@kamilmysliwiec
Copy link
Member

LGTM

@CemYil03 CemYil03 deleted the update-package-json-files branch April 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants