Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(core) property based injection (composition) #1172

Merged
merged 7 commits into from
Oct 19, 2018

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1014

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Oct 6, 2018

Pull Request Test Coverage Report for Build 1191

  • 53 of 62 (85.48%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 93.123%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/common/decorators/core/optional.decorator.ts 8 10 80.0%
packages/core/injector/module.ts 1 4 25.0%
packages/core/injector/injector.ts 28 32 87.5%
Totals Coverage Status
Change from base Build 1179: -0.4%
Covered Lines: 2690
Relevant Lines: 2825

💛 - Coveralls

@BrunnerLivio
Copy link
Member

Great job!
To clarify; this does not feature the proposed @Composition from #1014 property injection à la "inheritance-only-property-injection" / (similar like @Autowired in Spring), but a general "property-injection" right?

@kamilmysliwiec
Copy link
Member Author

Yes @BrunnerLivio :) (still recommended to use constructor injection instead)

@kamilmysliwiec kamilmysliwiec added this to the 5.4.0 milestone Oct 17, 2018
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 5.4.0 October 19, 2018 11:20
@kamilmysliwiec kamilmysliwiec merged commit a2ed524 into 5.4.0 Oct 19, 2018
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
@kamilmysliwiec kamilmysliwiec deleted the feature/property-injection branch January 24, 2020 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants