Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove void 0 not necessary #1199

Merged

Conversation

jbpionnier
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

if (this.invokeCustomFilters(exception, ctx)) {
return void 0;
}
if (this.invokeCustomFilters(exception, ctx)) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though void 0 is not necessarily required, please, let's stick with { ... } at least

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course

@jbpionnier jbpionnier changed the title feat/remove void 0 not necessary refactor: remove void 0 not necessary Oct 17, 2018
@coveralls
Copy link

coveralls commented Oct 17, 2018

Pull Request Test Coverage Report for Build 1162

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.631%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/exceptions/exceptions-handler.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 1157: 0.0%
Covered Lines: 2659
Relevant Lines: 2781

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Thanks @jbpionnier !

@kamilmysliwiec kamilmysliwiec merged commit a78a31e into nestjs:master Oct 17, 2018
@jbpionnier jbpionnier deleted the refactor/void_0_not_necessary branch October 18, 2018 09:48
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants