Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): throw on circular factories and custom providers #12020

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #11630

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8ff3efcf-664e-4098-9c48-22cfdcb38d74

  • 24 of 27 (88.89%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 92.853%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/settlement-signal.ts 8 9 88.89%
packages/core/injector/injector.ts 14 16 87.5%
Totals Coverage Status
Change from base Build 3dfb6545-1975-4a99-b2ed-aaa49f412a91: -0.01%
Covered Lines: 6379
Relevant Lines: 6870

💛 - Coveralls

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see a solution come in here. Tracing it back to that done promise was a bit of a doozy

@kamilmysliwiec kamilmysliwiec merged commit 4c37a2d into master Jul 17, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/throw-circular-custom-providers branch July 17, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants