Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(common): accept export abstract class #1208

Merged

Conversation

jbpionnier
Copy link
Contributor

@jbpionnier jbpionnier commented Oct 18, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Accept export Abstract class in the @module

@Module({
  providers: [
    {
      provide: MyAbstractFooClass,
      useValue: new MyImplFooClass(),
    },
  ],
  exports: [
    MyAbstractFooClass,
  ],

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Oct 18, 2018

Pull Request Test Coverage Report for Build 1170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.631%

Totals Coverage Status
Change from base Build 1167: 0.0%
Covered Lines: 2659
Relevant Lines: 2781

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Thanks @jbpionnier!

@kamilmysliwiec kamilmysliwiec merged commit 9210dc1 into nestjs:master Oct 19, 2018
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants