Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): create completed field on settlement for better tracking #12163

Merged
merged 1 commit into from Jul 31, 2023

Conversation

jmcdo29
Copy link
Member

@jmcdo29 jmcdo29 commented Jul 29, 2023

PR Type

Please check if your PR fulfills the following requirements:

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Currently, even correct circular dependencies can cause exceptions for seemingly no reason.

Issue Number: #12153

What is the new behavior?

With this new completed field, all properly managed circular dependencies work as anticipated.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build eab18eac-4ef9-4c02-a47d-31efd45ba489

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 92.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/settlement-signal.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
packages/core/injector/settlement-signal.ts 1 78.57%
Totals Coverage Status
Change from base Build de330e86-7c2b-484a-b17f-f872998b5610: -0.01%
Covered Lines: 6394
Relevant Lines: 6890

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit a1b0b45 into nestjs:master Jul 31, 2023
5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants