fix(socket.io): prevent multiple listeners for same socket on disconn… #12188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build cc9c3b19-08e3-4652-aaf6-045ec10f4668
💛 - Coveralls |
15 tasks
| let disconnect$ = this.disconnectFunctions.get(socket); | ||
| if (!disconnect$) { | ||
| disconnect$ = fromEvent(socket, DISCONNECT_EVENT).pipe(share(), first()); | ||
| this.disconnectFunctions.set(socket, disconnect$); |
There was a problem hiding this comment.
Where do you remove items from this collection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect event
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Fixed the issue of creating multiple listeners for the 'disconnect' event. Implemented a Map to store disconnect$ Observables for each socket. If disconnect$ is not available for the socket, a new Observable is created and stored.
What is the current behavior?
Previously, the io-adapter was creating multiple listeners for the 'disconnect' event, which was causing memory leaks.
Issue Number: 7249
What is the new behavior?
Now, the io-adapter creates only one listener for the 'disconnect' event, thereby eliminating the memory leaks.
Does this PR introduce a breaking change?
Other information