New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-ws): URL parsing error handled #12385
Merged
kamilmysliwiec
merged 2 commits into
nestjs:master
from
dbulic-margins:invalid-url-typeerror
Oct 5, 2023
Merged
fix(platform-ws): URL parsing error handled #12385
kamilmysliwiec
merged 2 commits into
nestjs:master
from
dbulic-margins:invalid-url-typeerror
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid URL TypeError handled with a try-catch block fixes nestjs#12381
Pull Request Test Coverage Report for Build b02a4722-7eed-42bf-9574-6e366bc9c115
💛 - Coveralls |
jmcdo29
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. How can we make sure this change is tested?
15 tasks
Maxwell0010
approved these changes
Sep 16, 2023
jmcdo29
approved these changes
Sep 17, 2023
Tony133
approved these changes
Sep 18, 2023
rubiin
approved these changes
Sep 19, 2023
@kamilmysliwiec I cannot merge this, who else needs to approve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid URL TypeError handled with a try-catch block
fixes #12381
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #12381
What is the new behavior?
In case of invalid URL socket is closed with an error message.
Does this PR introduce a breaking change?
Other information