Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core,common): 馃悰 missing registration handling of SEARCH http verb #13000

Merged
merged 3 commits into from Feb 7, 2024
Merged

fix(core,common): 馃悰 missing registration handling of SEARCH http verb #13000

merged 3 commits into from Feb 7, 2024

Conversation

doronguttman
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

see issue
Issue Number: #12998

What is the new behavior?

see issue

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jan 3, 2024 •
edited

Pull Request Test Coverage Report for Build 3dff09c4-230a-43c5-adfb-a3eaf0b9e253

  • 0 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 92.193%
Totals Coverage Status
Change from base Build 889ffab4-7a4b-4e81-8f8a-630e303f4274: -0.004%
Covered Lines: 6719
Relevant Lines: 7288
馃挍 - Coveralls

@kamilmysliwiec kamilmysliwiec mentioned this pull request Jan 3, 2024
Closed
15 tasks
@doronguttman
Copy link
Contributor Author

@kamilmysliwiec any chance this can be added in the next release?

@doronguttman doronguttman force-pushed the 12998-using-search-controller-method-decorator-hides-any-following-endpoints branch from 7ad245e to fc29bd7 Compare January 26, 2024 21:03
doronguttman added a commit to arnica-ext/nest that referenced this pull request Jan 31, 2024
@doronguttman
refactor(common): 鈾伙笍 PR nestjs#13000 comments
530bf40 
nestjs#13000
nestjs#12998
@doronguttman doronguttman force-pushed the 12998-using-search-controller-method-decorator-hides-any-following-endpoints branch from fc29bd7 to 530bf40 Compare January 31, 2024 19:03
@doronguttman doronguttman force-pushed the 12998-using-search-controller-method-decorator-hides-any-following-endpoints branch from 530bf40 to 33aae84 Compare January 31, 2024 19:04
@dammy001 dammy001 mentioned this pull request Feb 6, 2024
Closed
12 tasks
@kamilmysliwiec kamilmysliwiec merged commit f477d5b into nestjs:master Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjGam benjGam benjGam approved these changes

@dammy001 dammy001 Awaiting requested review from dammy001

@kamilmysliwiec kamilmysliwiec Awaiting requested review from kamilmysliwiec

Assignees
No one assigned
Labels
scope: common scope: core type: bug 馃槶
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@doronguttman @coveralls @kamilmysliwiec @dammy001 @benjGam