perf(common): Improve error handling for undefined tokens #13056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to issue nestjs#12914, this commit enhances the Nest.js injector for better debugging efficiency. The improvement involves throwing a specific error when a token is undefined, aiding developers in quicker problem identification and resolution. The error message provides guidance on potential circular dependencies and references for further assistance. Closes nestjs#12914
Pull Request Test Coverage Report for Build 8c8b0ae6-86ff-4e3d-b17d-10e4c691c7bb
💛 - Coveralls |
micalevisk
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM
btw this is not a perf change but a feat (according to angular convetions)
|
I can change my commit message and therefore the PR title if you're ok with that. |
dammy001
approved these changes
Jan 17, 2024
benjGam
approved these changes
Jan 17, 2024
Tony133
approved these changes
Jan 17, 2024
|
This is a breaking change. See #12914 (comment) |
|
Reverted #13370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #12914
What is the new behavior?
In response to issue #12914, this commit enhances the Nest.js injector for better debugging efficiency. The improvement involves throwing a specific error when a token is undefined, aiding developers in quicker problem identification and resolution. The error message provides guidance on potential circular dependencies and references for further assistance.
Does this PR introduce a breaking change?
Other information