Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservice) Delete unnecessary call of grpcClient.start #13283

Merged
merged 2 commits into from Mar 17, 2024

Conversation

youngkiu
Copy link
Contributor

@youngkiu youngkiu commented Mar 1, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

(node:66623) DeprecationWarning: Calling start() is no longer necessary. It can be safely omitted.
    at ServerGrpc.start (<PATH>/node_modules/@nestjs/microservices/server/server-grpc.js:39:25)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ServerGrpc.listen (<PATH>/node_modules/@nestjs/microservices/server/server-grpc.js:31:13)

The above warning message appeared, so even if I deleted this.grpcClient.start(); and ran it, it worked normally.

@kamilmysliwiec
Copy link
Member

Could you please update unit tests?

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build c45d97c3-4f7b-4739-b79c-0970a270f8df

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 92.159%

Files with Coverage Reduction New Missed Lines %
packages/microservices/server/server-grpc.ts 11 92.23%
Totals Coverage Status
Change from base Build 2bf2e4c8-5da9-4dd1-8f93-3b733029afc6: -0.001%
Covered Lines: 6735
Relevant Lines: 7308

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit dad9ba3 into nestjs:master Mar 17, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec
Copy link
Member

I'm going to temporarily revert this PR to avoid introducing a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants