Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): break reference chain to instance object #13366

Merged
merged 1 commit into from Mar 27, 2024

Conversation

breeeew
Copy link
Contributor

@breeeew breeeew commented Mar 27, 2024

Reference caused in getContextFactory, and it stored in handlerMetadataStorage in Map, that never be purged

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

issue

Issue Number: 13365

What is the new behavior?

same, but without leak

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reference caused in getContextFactory, and it stored in handlerMetadataStorage in Map, that never be purged
@breeeew
Copy link
Contributor Author

breeeew commented Mar 27, 2024

Sorry, but I can't figure out how to write tests for this

@coveralls
Copy link

Pull Request Test Coverage Report for Build 313c391e-2e75-4829-9f2c-92b11880aea0

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/helpers/context-utils.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 6bb059e7-7c5e-42b3-ae34-83ddafc5213b: 0.0%
Covered Lines: 6734
Relevant Lines: 7308

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit f29f932 into nestjs:master Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants