Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples(config) Provide an example of 12-factor configuration #1573

Closed
wants to merge 1 commit into from
Closed

samples(config) Provide an example of 12-factor configuration #1573

wants to merge 1 commit into from

Conversation

kibertoad
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Other... Please describe:

Improved sample to provide a real-world configuration example

What is the current behavior?

Sample uses hardcoded value

Issue Number: #1566

What is the new behavior?

Sample uses value from configuration

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@kamilmysliwiec
Copy link
Member

Thank you for your contribution. Unluckily, I can't merge it. See my post here: https://github.com/nestjs/nest/issues/1566

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants