Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(common): prevent exception body override if message is an array #1623

Merged

Conversation

sincraianul
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1622

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1596

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 94.425%

Totals Coverage Status
Change from base Build 1580: 0.003%
Covered Lines: 2636
Relevant Lines: 2752

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1596

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 94.425%

Totals Coverage Status
Change from base Build 1580: 0.003%
Covered Lines: 2636
Relevant Lines: 2752

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1596

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 94.425%

Totals Coverage Status
Change from base Build 1580: 0.003%
Covered Lines: 2636
Relevant Lines: 2752

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit d6b8e1f into nestjs:master Mar 9, 2019
@kamilmysliwiec
Copy link
Member

Thanks! I'll publish the patch release shortly :)

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants