feat(@nestjs/core): Add Transient Inquirer Injection

[Aetherall]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

In a transient injectable, the current instance is bound to the context in which it is instanciated.
However, there is no way I am aware of to configure the behaviour of the injected injectable at the intanciation level

What is the new behavior?

This PR introduce a way to achieve this intention by adding a new provider in the InternalCoreModule.
The injection of the INQUIRER symbol token results in the inquirer to be injected into our transient injectable.

@Inject(INQUIRER) inquirer

An example with a concrete business use-case is available in the PR

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The way we implemented the feature may not be ideal given the architecture of the injection mechanism, so @millehorde and myself are willing to take all measures you consider appropriated

[coveralls]

Pull Request Test Coverage Report for Build 1612

• 13 of 15 (86.67%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 93.033%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/core/injector/injector.ts	6	8	75.0%

Totals
Change from base Build 1599:	-0.1%
Covered Lines:	3295
Relevant Lines:	3448

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1612

• 11 of 13 (84.62%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+2.4%) to 95.563%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/core/injector/injector.ts	4	6	66.67%

Totals
Change from base Build 1599:	2.4%
Covered Lines:	3295
Relevant Lines:	3448

---

💛 - Coveralls

[kamilmysliwiec]

Thanks for contribution! I'll review shortly

[nesimer]

Thanks ! 🔥
We rebased it on your latest work !

[kamilmysliwiec]

I have finally found some time to look at this PR. Amazing job, thank you!

[msheakoski]

@Aetherall I am trying to better understand as an end user how/when/why I would use this since there is no documentation yet. I read through the specs/code, but still cannot figure out what is going on. Are you able to give a simple example of a situation where this feature would be a good use case? Thank you!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.