Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(microservices): add multiple proto to grpc config #1774

Closed
wants to merge 1 commit into from

Conversation

AlexDaSoul
Copy link

@AlexDaSoul AlexDaSoul commented Mar 19, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1640

grpcOptions: {
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: 'alone.proto'
    }
}

What is the new behavior?

grpcOptions: {
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: [
        'one.proto',
        'two.proto',
        'any.proto'
        ]
    }
}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

before:
grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: 'alone.proto'
    }
}
after:
grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: [
        'one.proto',
        'two.proto',
        'any.proto'
        ]
    }
}
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1987

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.696%

Totals Coverage Status
Change from base Build 1974: 0.0%
Covered Lines: 2996
Relevant Lines: 3141

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 19, 2019

Pull Request Test Coverage Report for Build 1987

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.696%

Totals Coverage Status
Change from base Build 1974: 0.0%
Covered Lines: 2996
Relevant Lines: 3141

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

I don't think that this PR actually solves #1640. Let's track this here #1733

@AlexDaSoul
Copy link
Author

I don't think that this PR actually solves #1640. Let's track this here #1733

#1733 have a flaw - this works only for decorations, but not for the client. Need https://github.com/nestjs/nest/pull/1774/files#diff-961699c6f9192f31ba318b6ec1915084 for correctly work

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
@AlexDaSoul AlexDaSoul deleted the grpc-multiple-proto branch October 2, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants