Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lerna functionality #202

Closed
wants to merge 10 commits into from
Closed

Add Lerna functionality #202

wants to merge 10 commits into from

Conversation

wbhob
Copy link
Contributor

@wbhob wbhob commented Oct 23, 2017

This PR will use lerna for managing the monorepo. This addresses #68. I have mapped the npm publish command to lerna publish, so there should not be much difference.

Important note: I have mapped lerna to src. I don't have a valid build command on the current repo, so change the property in lerna.json to whatever the build directory is.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.951% when pulling 598056a on wbhob:lerna into dc7869b on nestjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.951% when pulling 598056a on wbhob:lerna into dc7869b on nestjs:master.

@wbhob
Copy link
Contributor Author

wbhob commented Oct 30, 2017

Fixed merge conflicts

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.951% when pulling 9a04b40 on wbhob:lerna into dc7869b on nestjs:master.

@kamilmysliwiec
Copy link
Member

Hi @wbhob,
I appreciate your work but honestly, I don't see the reason why we need an additional tool to manage only 5 repos 🙁 Lerna is great, but we don't need it since all of the repositories may have a different release number.

@wbhob
Copy link
Contributor Author

wbhob commented Oct 31, 2017

So that’s the thing: they should all have the same release number, because they are codependent. It will get very confusing VERY fast if there are more packages or some packages have minor versions. Like angular, it’s kmportant to have every package on the same version for developer experience.

@wbhob
Copy link
Contributor Author

wbhob commented Nov 2, 2017

@kamilmysliwiec can you see my previous comment and tell me your thoughts?

On the whole, I think it's good that we have tools like Lerna at our disposal, so we don't have to write scripts ourselves.

@MonsieurMan
Copy link

MonsieurMan commented Nov 2, 2017

I'm on par with @wbhob, if packages come as a bundle they should definitely have the same version number even if no changes were introduced, it's going to be a hell if we have to keep track of which version works with which other.

@kamilmysliwiec
Copy link
Member

Thanks @wbhob @MonsieurMan - you convinced me 🙂 Lerna is here now

@wbhob wbhob deleted the lerna branch November 4, 2017 16:58
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants