-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lerna functionality #202
Conversation
Fixed merge conflicts |
Hi @wbhob, |
So that’s the thing: they should all have the same release number, because they are codependent. It will get very confusing VERY fast if there are more packages or some packages have minor versions. Like angular, it’s kmportant to have every package on the same version for developer experience. |
@kamilmysliwiec can you see my previous comment and tell me your thoughts? On the whole, I think it's good that we have tools like Lerna at our disposal, so we don't have to write scripts ourselves. |
I'm on par with @wbhob, if packages come as a bundle they should definitely have the same version number even if no changes were introduced, it's going to be a hell if we have to keep track of which version works with which other. |
Thanks @wbhob @MonsieurMan - you convinced me 🙂 Lerna is here now |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR will use lerna for managing the monorepo. This addresses #68. I have mapped the
npm publish
command tolerna publish
, so there should not be much difference.Important note: I have mapped lerna to
src
. I don't have a valid build command on the current repo, so change the property inlerna.json
to whatever the build directory is.