Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Multer): Add any file interceptor #2496

Merged

Conversation

Samox
Copy link
Contributor

@Samox Samox commented Jul 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

If you receive a multipart request with random names of your files (e.g. uuid) you cannot gather all of them. But Multer allows it with any.

Issue Number: N/A

What is the new behavior?

An interceptor for the multer any is now available.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Jul 2, 2019

Pull Request Test Coverage Report for Build 3537

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.173%

Totals Coverage Status
Change from base Build 3532: 0.02%
Covered Lines: 3549
Relevant Lines: 3729

💛 - Coveralls

@Samox Samox force-pushed the add-any-files-multer-interceptor branch 4 times, most recently from 533901c to 53b18be Compare July 4, 2019 11:03
@Samox
Copy link
Contributor Author

Samox commented Jul 4, 2019

Related Doc nestjs/docs.nestjs.com#494

@Samox Samox force-pushed the add-any-files-multer-interceptor branch from 53b18be to b25754d Compare July 8, 2019 13:21
@kamilmysliwiec
Copy link
Member

Thank you! :)

@kamilmysliwiec kamilmysliwiec merged commit 8a9af18 into nestjs:master Jul 9, 2019
@tychota
Copy link
Contributor

tychota commented Jul 9, 2019

🥳

@lock
Copy link

lock bot commented Oct 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants