Add contribution guidelines v1 #250
Conversation
…s properly formatted. I\'ve included a command, [20:37:16] Using gulpfile ~/nest/gulpfile.js [20:37:16] Starting 'format'... [20:37:22] Finished 'format' after 5.76 s that will take care of this for you.\nThis functionality is taken directly from Angular's repository.
…commit is properly formatted. I\'ve included a command, [20:37:16] Using gulpfile ~/nest/gulpfile.js" This reverts commit c4a3e02.
| @@ -1,6 +1,6 @@ | |||
| # dependencies | |||
| node_modules/ | |||
|
|
|||
| package-lock.json | |||
There was a problem hiding this comment.
Isn't the whole purpose of this file to be versioned ?
There was a problem hiding this comment.
For some reason Kamil keeps removing it from the repo, so I thought I'd add it to gitignore
There was a problem hiding this comment.
You shouldn't have done it in this PR if it's not related to it then. You're creating side effects, haha.
@kamilmysliwiec what's up with it ?
CONTRIBUTING.md
Outdated
|
|
||
| We have very precise rules over how our git commit messages can be formatted. This leads to **more | ||
| readable messages** that are easy to follow when looking through the **project history**. But also, | ||
| we use the git commit messages to **generate the Angular change log**. |
There was a problem hiding this comment.
Angular made it's way through !
By the way is there really no way we can suggest changes to a PR ?
There was a problem hiding this comment.
In your PR review, just set it to rejected
| [print, sign and one of scan+email, fax or mail the form][corporate-cla]. --> | ||
|
|
||
|
|
||
| <!-- [angular-group]: https://groups.google.com/forum/#!forum/angular --> |
There was a problem hiding this comment.
I commented it out here, since I don't really know what to do with this link for now 😄
|
|
||
|
|
||
| <!-- [angular-group]: https://groups.google.com/forum/#!forum/angular --> | ||
| <!-- [coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md --> |
There was a problem hiding this comment.
Here also !
As the SO part below, waiting for further work ?
| [jsfiddle]: http://jsfiddle.net | ||
| [plunker]: http://plnkr.co/edit | ||
| [runnable]: http://runnable.com | ||
| <!-- [stackoverflow]: http://stackoverflow.com/questions/tagged/angular --> |
There was a problem hiding this comment.
And here too !
I guess you commented it out until we have further information about SO ?
| - and most importantly - a use-case that fails | ||
|
|
||
| <!-- | ||
| // TODO we need to create a playground, similar to plunkr |
There was a problem hiding this comment.
We need to file an issue for this one.
There was a problem hiding this comment.
I'll probably hack one together
| * **packaging**: used for changes that change the npm package layout in all of our packages, e.g. public path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc. | ||
| * **changelog**: used for updating the release notes in CHANGELOG.md | ||
| * **examples/#**: for the example apps directory, replacing # with the example app number | ||
| <!-- * **aio**: used for docs-app (angular.io) related changes within the /aio directory of the repo --> |
There was a problem hiding this comment.
Also, it is commented out until we need this line
|
Looks good 🙂 thanks @wbhob for your effort. Should I take care of the rest? |
|
Yeah, @kamilmysliwiec this is more just a starting point. It's literally a copy/paste from Angular's contribution guidelines. Feel free to adjust where you see fit. |
|
@kamilmysliwiec what do I need to do to get this merged? |
|
Do you have an update @kamilmysliwiec ? |
|
🎉 |
|
That's good for now. Thanks @wbhob :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is the first attempt at writing contribution guidelines for Nest.