Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): update error messaging to provide solutions #3001

Merged
merged 10 commits into from
Sep 30, 2019

Conversation

MarkPieszak
Copy link
Member

What is the new behavior?

Updated error messaging to provide solutions and pinpoint where the issue is stemming from.

Does this PR introduce a breaking change?

[x] No

Other information

image

@coveralls
Copy link

coveralls commented Sep 21, 2019

Pull Request Test Coverage Report for Build 2858

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.349%

Totals Coverage Status
Change from base Build 2792: 0.0%
Covered Lines: 4141
Relevant Lines: 4343

💛 - Coveralls


if (isNil(index)) {
message += `. Please make sure that the "${key.toString()}" property is available in the current context.`;
message += `.\nPlease make sure that the "${key.toString()}" property is available in the current context.`;
return message;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add potential solutions here as well.

(side note: index is nil when the property-based injection is used - no constructor. The rest remains the same)

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.8.0 September 30, 2019 08:14
@kamilmysliwiec kamilmysliwiec added this to the 6.8.0 milestone Sep 30, 2019
@kamilmysliwiec kamilmysliwiec merged commit 323f289 into nestjs:6.8.0 Sep 30, 2019
@kamilmysliwiec kamilmysliwiec mentioned this pull request Sep 30, 2019
3 tasks
@lock
Copy link

lock bot commented Dec 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants