Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): add subscribe and from beginning to kafka options #4146

Merged

Conversation

theabuitendyk
Copy link
Contributor

@theabuitendyk theabuitendyk commented Feb 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3739

What is the new behavior?

KafkaOptions includes support for the kafka.js subscribe fromBeginning option.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15907

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 95.065%

Totals Coverage Status
Change from base Build 15874: 0.002%
Covered Lines: 4565
Relevant Lines: 4802

💛 - Coveralls

@theabuitendyk
Copy link
Contributor Author

@kamilmysliwiec What's the typical timeline for releasing a change like this to master if it's approved? Our team has a project that is blocked without the fromBeginning option, so we're prepared to fork nestjs in the meantime if it's a ways out but would prefer not to.

Thank you for nestjs. 🙂I've really enjoyed working with the framework so far!

@kamilmysliwiec
Copy link
Member

Thanks!

@kamilmysliwiec kamilmysliwiec merged commit 99ac48b into nestjs:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants