Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests to make them run ootb #4633

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

apatryda
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4632

What is the new behavior?

Described in the related issue.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Apr 20, 2020

Pull Request Test Coverage Report for Build 21059

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.632%

Totals Coverage Status
Change from base Build 21026: 0.0%
Covered Lines: 4689
Relevant Lines: 4955

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Can you remove generated package-lock.json files? (within packages directory). We can add them to the .gitignore file

@apatryda
Copy link
Contributor Author

Yes, I can, although I added them on purpose. Without them it is impossible to bootstrap packages quickly and predictably.

@kamilmysliwiec kamilmysliwiec merged commit f4d8fad into nestjs:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants