Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update core dependency: remove direct dependency on body-parser #537

Closed
wants to merge 1 commit into from
Closed

update core dependency: remove direct dependency on body-parser #537

wants to merge 1 commit into from

Conversation

Meir017
Copy link

@Meir017 Meir017 commented Apr 1, 2018

since express depends on body-parser directly there is no need to depend on a specific version of express and body-parser

https://github.com/expressjs/express/blob/master/package.json#L32

@Meir017 Meir017 changed the title core: remove direct depndency on body-parser update core dependency: remove direct dependency on body-parser Apr 1, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.878% when pulling bc72874 on Meir017:patch-2 into 1ca812a on nestjs:master.

@Meir017
Copy link
Author

Meir017 commented Apr 17, 2018

@kamilmysliwiec @thomrick any update on this?

@kamilmysliwiec
Copy link
Member

What's the benefit here? As I remember body-parser has a vulnerability (#517) and it would be safer to enforce recent version.

@Meir017 Meir017 closed this Apr 28, 2018
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants