Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sample-14): added unit test and other improvements #8402

Merged
merged 12 commits into from
Oct 29, 2021

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Oct 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1539

What is the new behavior?

Added unit tests in sample sample-14-mongoose-base and other improvements.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR, added unit tests in sample sample-14-mongoose-base and other improvements.

@Tony133
Copy link
Contributor Author

Tony133 commented Oct 21, 2021

PR to evaluate 👀 🤞😻

@coveralls
Copy link

coveralls commented Oct 21, 2021

Pull Request Test Coverage Report for Build ba3acf56-db4e-4ab0-a906-3414061031c1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.174%

Totals Coverage Status
Change from base Build 8bef8cae-6c99-4a3b-8be5-5ff1febbdda7: 0.0%
Covered Lines: 5658
Relevant Lines: 6008

💛 - Coveralls

Tony133 and others added 3 commits October 27, 2021 16:23
Co-authored-by: Kamil Mysliwiec <mail@kamilmysliwiec.com>
Co-authored-by: Kamil Mysliwiec <mail@kamilmysliwiec.com>
@kamilmysliwiec kamilmysliwiec merged commit 1394305 into nestjs:master Oct 29, 2021
@kamilmysliwiec
Copy link
Member

LGTM

@Tony133 Tony133 deleted the test/sample-14-mongoose-base branch July 9, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants