feat(microservices): support ncc when using grpc #8615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A well-performed nestjs standard project, which transport is
Transport.GRPC
and protoLoader is@grpc/proto-loader
, is not compatible with npm package@vercel/ncc
. The reason is - ncc compiling js file use static analysation. Therefore,require(someVar)
is not supported by ncc, butrequire("some-string")
works well.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
nest build
in a standard nestjs project that its transport isTransport.GRPC
and its protoLoader is@grpc/proto-loader
npm i -g @vercel/ncc && ncc build dist/main.js -m -o out
node out/index.js
to bootstrap, but failWhat is the new behavior?
nest build
in a standard nestjs project that its transport isTransport.GRPC
and its protoLoader is@grpc/proto-loader
npm i -g @vercel/ncc && ncc build dist/main.js -m -o out
node out/index.js
to bootstrap, success.Does this PR introduce a breaking change?
Other information