feat(microservices): add new extras param to MessagePattern and EventPattern decorators
#8933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional "extras" parameter for MessagePattern and EventPattern decorators. Allow embedding extra params into each message handler method and improve an experience of creating custom microservice transports
Pull Request Test Coverage Report for Build f2ee145d-72db-4fdd-936e-4ab6cb4d6b2c
💛 - Coveralls |
|
@kamilmysliwiec could you take a quick look at this PR once you have a chance. |
|
I'll look into this as soon as I can! |
EugeneKorshenko
force-pushed
the
feature/package_microservices/add_extras_to_pattern_decorators
branch
from
84e545a
to
a0f148d
Compare
|
I'm looking forward to see this implemented, currently I'm trying to build a custom transport and adding metadata to the message pattern has been a pain but this simply things @EugeneKorshenko thanks for the PR |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current implementation allows passing only
patternandtransportto the microservice transport. No way to attach any handler-specific rich types.Issue Number: N/A
What is the new behavior?
The new implementation adds optional "extras" parameter for
MessagePatternandEventPatterndecorators that allows embedding any extra params into each message handler method and improves the experience of creating custom microservice transports.Does this PR introduce a breaking change?
Other information