Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(@nestjs/core) enable dynamic modules recursive imports #671 #900

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@kamilmysliwiec
Copy link
Member Author

Solves #671

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.579% when pulling 432b777 on bugfix/671-dynamic-modules into e39c9d9 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.579% when pulling 432b777 on bugfix/671-dynamic-modules into e39c9d9 on master.

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 5.2.0 July 25, 2018 18:03
@kamilmysliwiec kamilmysliwiec merged commit 55b1f1e into 5.2.0 Jul 25, 2018
@kamilmysliwiec kamilmysliwiec deleted the bugfix/671-dynamic-modules branch August 22, 2018 13:49
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants