Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix factory provider definition #9023

Merged
merged 1 commit into from May 17, 2022

Conversation

zanminkian
Copy link
Contributor

@zanminkian zanminkian commented Jan 25, 2022

According to this document, if factory provider's useFactory function is async, useFactory function should return Promise<T>.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5fc2f9c8-81c3-4daa-9162-8f82444480a5

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.13%

Totals Coverage Status
Change from base Build 6c6442b4-a131-4d7f-a0f8-d2eb1814def7: 0.0%
Covered Lines: 5693
Relevant Lines: 6048

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

This is a breaking change so we might need to postpone it till the next major release.

@micalevisk
Copy link
Member

@kamilmysliwiec could you add the label status: blocked 🚫 to this PR

@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 13, 2022
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 May 17, 2022 11:13
@kamilmysliwiec kamilmysliwiec merged commit 2065792 into nestjs:9.0.0 May 17, 2022
@kamilmysliwiec kamilmysliwiec mentioned this pull request May 20, 2022
12 tasks
@zanminkian zanminkian deleted the fix/factory-provider-type branch October 11, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants