Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove fastify deprecation warning #9741

Closed
wants to merge 1 commit into from

Conversation

Eomm
Copy link
Contributor

@Eomm Eomm commented Jun 7, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

A warning is shown

(node:31444) [FST_MODULE_DEP_FASTIFY-FORMBODY] FastifyWarning.fastify-formbody: fastify-formbody has been deprecated. Use @fastify/formbody@6.0.0 instead.
(Use `node --trace-warnings ...` to show where the warning was created)

Issue Number: N/A

What is the new behavior?

The new fastify's plugin major releases contain only the module rename without the warning.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Ref fastify/fastify-formbody#116

@Eomm Eomm changed the title chore: remove fastify deprecation warning chore(deps): remove fastify deprecation warning Jun 7, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build fcf027b5-8a01-46df-b917-ade8be4544ce

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.107%

Totals Coverage Status
Change from base Build 3833bc5d-ac71-4db9-b614-33791ff96fb8: 0.0%
Covered Lines: 5781
Relevant Lines: 6143

💛 - Coveralls

@Tony133
Copy link
Contributor

Tony133 commented Jun 7, 2022

Updates to the fastify packages will be released with the release of version v9 of Nest.
See this PR: #9588

@kamilmysliwiec
Copy link
Member

Tracking this here #9588

@Eomm
Copy link
Contributor Author

Eomm commented Jun 25, 2022

Updates to the fastify packages will be released with the release of version v9 of Nest. See this PR: #9588

The users that are stick to v8 will read the warning forever
The upgrade included in this PR is good with v8 tho

@Tony133
Copy link
Contributor

Tony133 commented Jun 25, 2022

The users that are stick to v8 will read the warning forever
The upgrade included in this PR is good with v8 tho

As soon as Nest's v9 comes out there will be no updates or security patches for v8, at least that's always been the case, i don't know how the Nest Core Team will want to set things up in the future, but I think it was a very big change, so they thought about putting it in the main version (v9).

Although let me tell you something, the Fastify plugins (@fastify/cors, @fastify/swagger, @fastify/helmet, etc.), if I'm not mistaken, have been updated before fastify 4.x so I think this may have affected the update in v8 and moved in to v9, in order to update fastify 4.x as well.

@kamilmysliwiec
Copy link
Member

As soon as Nest's v9 comes out there will be no updates or security patches for v8, at least that's always been the case, i don't know how the Nest Core Team will want to set things up in the future, but I think it was a very big change, so they thought about putting it in the main version (v9).

This isn't correct @Tony133.

The users that are stick to v8 will read the warning forever
The upgrade included in this PR is good with v8 tho

We can't upgrade Fastify packages as part of v8 as this would introduce a breaking change. Breaking change = new major release.

@nestjs nestjs locked and limited conversation to collaborators Jun 25, 2022
@Eomm Eomm deleted the patch-1 branch June 27, 2022 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants