Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not found: Error: Can't resolve 'string-replace-loader' in... #64

Closed
tuurbo opened this issue Apr 25, 2019 · 1 comment
Closed

Comments

@tuurbo
Copy link

tuurbo commented Apr 25, 2019

I'm submitting a...


[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

string-replace-loader used in https://github.com/nestjs/ng-universal/blob/3e491cb46c7387651a7f91b597e14a661820f2fb/lib/webpack-config.factory.ts

Expected behavior

string-replace-loader should be a dependency by default?

Minimal reproduction of the problem with instructions

Error can be fixed by yarn add string-replace-loader --dev

What is the motivation / use case for changing the behavior?

Environment

"@nestjs/common": "6.1.1",
"@nestjs/core": "6.1.1",
"@nestjs/ng-universal": "1.0.2",
"@nestjs/platform-express": "6.1.1",
"@nestjs/testing": "6.1.1",
"@nest-middlewares/compression": "6.0.0",
"@nest-middlewares/express-session": "6.0.0",
"@nest-middlewares/helmet": "6.0.0",
@kamilmysliwiec
Copy link
Member

Fixed in 1.1.0 :) Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants