Merge pull request #1320 from nestjs/10.0.0

chore: laying the grounds for v10.0.0

.circleci/config.yml

@@ -3,15 +3,15 @@ version: 2
 aliases:
   - &restore-cache
     restore_cache:
-        key: dependency-cache-{{ checksum "package.json" }}
+      key: dependency-cache-{{ checksum "package.json" }}
   - &install-deps
     run:
-        name: Install dependencies
-        command: npm ci
+      name: Install dependencies
+      command: npm ci --ignore-scripts
   - &build-packages
     run:
-        name: Build
-        command: npm run build
+      name: Build
+      command: npm run build
 
 jobs:
   build:
@@ -27,7 +27,7 @@ jobs:
           key: dependency-cache-{{ checksum "package.json" }}
       - run:
           name: Install dependencies
-          command: npm ci
+          command: npm ci --ignore-scripts
       - save_cache:
           key: dependency-cache-{{ checksum "package.json" }}
           paths:
@@ -44,4 +44,3 @@ workflows:
   build-and-test:
     jobs:
       - build
-

lib/auth.guard.ts

@@ -31,14 +31,16 @@ export type IAuthGuard = CanActivate & {
   getAuthenticateOptions(
     context: ExecutionContext
   ): IAuthModuleOptions | undefined;
+  getRequest<T = any>(context: ExecutionContext): T;
 };
+
 export const AuthGuard: (type?: string | string[]) => Type<IAuthGuard> =
   memoize(createAuthGuard);
 
 const NO_STRATEGY_ERROR = `In order to use "defaultStrategy", please, ensure to import PassportModule in each place where AuthGuard() is being used. Otherwise, passport won't work correctly.`;
 const authLogger = new Logger('AuthGuard');
 
-function createAuthGuard(type?: string | string[]): Type<CanActivate> {
+function createAuthGuard(type?: string | string[]): Type<IAuthGuard> {
   class MixinAuthGuard<TUser = any> implements CanActivate {
     @Optional()
     @Inject(AuthModuleOptions)
@@ -103,7 +105,7 @@ function createAuthGuard(type?: string | string[]): Type<CanActivate> {
     }
   }
   const guard = mixin(MixinAuthGuard);
-  return guard;
+  return guard as Type<IAuthGuard>;
 }
 
 const createPassportContext =

lib/passport/passport.strategy.ts

@@ -3,7 +3,8 @@ import { Type } from '../interfaces';
 
 export function PassportStrategy<T extends Type<any> = any>(
   Strategy: T,
-  name?: string | undefined
+  name?: string | undefined,
+  callbackArity?: true | number
 ): {
   new (...args): InstanceType<T>;
 } {
@@ -24,17 +25,17 @@ export function PassportStrategy<T extends Type<any> = any>(
           done(err, null);
         }
       };
-      /**
-       * Commented out due to the regression it introduced
-       * Read more here: https://github.com/nestjs/passport/issues/446
 
+      if (callbackArity !== undefined) {
         const validate = new.target?.prototype?.validate;
+        const arity =
+          callbackArity === true ? validate.length + 1 : callbackArity;
         if (validate) {
           Object.defineProperty(callback, 'length', {
-            value: validate.length + 1
+            value: arity
           });
         }
-      */
+      }
       super(...args, callback);
 
       const passportInstance = this.getPassportInstance();

package.json

@@ -22,7 +22,7 @@
     "index.d.ts"
   ],
   "peerDependencies": {
-    "@nestjs/common": "^8.0.0 || ^9.0.0",
+    "@nestjs/common": "^8.0.0 || ^9.0.0 || ^10.0.0",
     "passport": "^0.4.0 || ^0.5.0 || ^0.6.0"
   },
   "devDependencies": {

tsconfig.build.json

@@ -7,7 +7,7 @@
     "noLib": false,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
-    "target": "es6",
+    "target": "ES2021",
     "sourceMap": false,
     "outDir": "./dist",
     "rootDir": "./lib",