Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove dev dependency @types/cron #1356

Conversation

sheerlox
Copy link
Contributor

@sheerlox sheerlox commented Jul 24, 2023

As of version 2.4.0 of cron, types are bundled with the library.

This PR removes the @types/cron dev dependency in package.json, and removes the installation instruction about that same package in README.md, streamlining the installation of @nestjs/schedule to a single line.

Note: this PR targets the Renovate Bot PR #1355 to make it easier for maintainers to merge these related changes.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Development dependencies & documentation update

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Related PR: DefinitelyTyped/DefinitelyTyped#66164

Commands ran (successfully) to test the changes:

$ npm run build
$ npm run test:integration

@kamilmysliwiec kamilmysliwiec merged commit 923467c into nestjs:renovate/cron-2.x Jul 25, 2023
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants