Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct path in start:prod script with sub apps #1169

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix: use correct path in start:prod script with sub apps #1169

merged 1 commit into from
Sep 12, 2022

Conversation

MitchellCash
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If using sub apps inside a monorepo running npm run build or nest build <app_name> puts the build files inside the path dist/apps/<app_name>.

However, the npm run start:prod script still points to dist/main - the old location before the project became a monorepo.

What is the new behavior?

npm run start:prod now points to dist/apps/<app_name>/main

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A

Tony133
Tony133 reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change regarding the indentation of the code

src/lib/sub-app/sub-app.factory.ts Outdated Show resolved Hide resolved
@kamilmysliwiec kamilmysliwiec merged commit 4430d43 into nestjs:master Sep 12, 2022
@MitchellCash MitchellCash deleted the fix-start-prod-script branch September 12, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony133 Tony133 Tony133 left review comments

@kamilmysliwiec kamilmysliwiec kamilmysliwiec approved these changes

@jmcdo29 jmcdo29 jmcdo29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MitchellCash @Tony133 @kamilmysliwiec @jmcdo29