fix(sub-app): dry-run #1232
Merged
fix(sub-app): dry-run #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
src/lib/sub-app/sub-app.factory.ts
Outdated
Comment on lines
256
to
261
| // mv src | ||
| moveDirectories(sourceRoot, join(projectRoot as Path, appName), host); | ||
|
|
||
| // mv tests | ||
| const testDir = 'test'; | ||
| moveDirectories(testDir, join(projectRoot as Path, appName), host); |
There was a problem hiding this comment.
Suggested change
| // mv src | |
| moveDirectories(sourceRoot, join(projectRoot as Path, appName), host); | |
| // mv tests | |
| const testDir = 'test'; | |
| moveDirectories(testDir, join(projectRoot as Path, appName), host); | |
| moveDirectories(sourceRoot, join(projectRoot as Path, appName), host); | |
| const testDir = 'test'; | |
| moveDirectories(testDir, join(projectRoot as Path, appName), host); |
code seems to be self-explanatory(?)
There was a problem hiding this comment.
I've removed these comments ✔️
Dry run for the sub-app generator was creating new directories stracture anyway. Closes nestjs/nest-cli#1513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dry run for the sub-app generator was
creating new directories stracture anyway.
Closes #1234
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1234
What is the new behavior?
Using
nest g -d app my-appdoesn't introduce any changes to the filesDoes this PR introduce a breaking change?
Other information