Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): adding missing types to resource schematic #562

Merged
merged 3 commits into from
Jan 22, 2021
Merged

chore(): adding missing types to resource schematic #562

merged 3 commits into from
Jan 22, 2021

Conversation

Thomas-Waldbillig
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Currently when using the angular console plugin from nrwl some parameters for the resource schematic show up as text fields, even though they are boolean values.

Issue Number: 561

What is the new behavior?

Schematic fields show up correctly in angular-console plugin

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

Would you like to add these types to other schematics as well?

@Thomas-Waldbillig
Copy link
Contributor Author

i can have a look at others as well.
but this one was the most important one for me since this one is missing in the @nrwl/nest schematics

@Thomas-Waldbillig
Copy link
Contributor Author

rebased the branch and added missing types for other schematics

@kamilmysliwiec kamilmysliwiec merged commit 92a2f64 into nestjs:master Jan 22, 2021
@kamilmysliwiec
Copy link
Member

Thanks! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants