Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove prettier/@typescript-eslint from eslint config #1405

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

mo4islona
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

npm run lint is broken

 npm run lint

> @nestjs/swagger@4.8.0 lint
> eslint 'lib/**/*.ts' --fix


Oops! Something went wrong! :(

ESLint: 7.27.0

Error: Cannot read config file: /swagger/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: /swagger/.eslintrc.js
    at Object.<anonymous> (/swagger/node_modules/eslint-config-prettier/@typescript-eslint.js:1:69)
    at Module._compile (/swagger/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:933:32)
    at Function.Module._load (internal/modules/cjs/loader.js:774:14)
    at Module.require (internal/modules/cjs/loader.js:957:19)
    at module.exports (/swagger/node_modules/import-fresh/index.js:31:59)
    at loadJSConfigFile (/swagger/node_modules/@eslint/eslintrc/lib/config-array-factory.js:225:16)
    at loadConfigFile (/swagger/node_modules/@eslint/eslintrc/lib/config-array-factory.js:309:20)
    at ConfigArrayFactory._loadConfigData (/swagger/node_modules/@eslint/eslintrc/lib/config-array-factory.js:609:42)
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?


> @nestjs/swagger@4.8.0 lint
> eslint 'lib/**/*.ts' --fix

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 2b27e14 into nestjs:master Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants