fix: number enum generated schema type #2238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, if you create a number enum property like this:
It will then generate a correct schema for this param:
But if you add an “enumName“ parameter, so that the enum will get its own schema entry like this:
It will change the type of the enum in the schema from 'number' to 'string':
What is the new behavior?
I made it so it saves the type, if is was given before.
So if we take our previous example:
It will now generate a correct schema for this enum:
Does this PR introduce a breaking change?
Other information