feat: Added function type for enum #2852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slukes
reviewed
Feb 27, 2024
| @@ -57,6 +59,13 @@ describe('SchemaObjectFactory', () => { | |||
|
|
|||
| @ApiProperty({ enum: Ranking, enumName: 'Ranking', isArray: true }) | |||
| rankings: Ranking[]; | |||
|
|
|||
| @ApiProperty({ | |||
| enum: getAvailableUserRoles(), | |||
There was a problem hiding this comment.
I think here you need to change this to be
Suggested change
| enum: getAvailableUserRoles(), | |
| enum: getAvailableUserRoles, |
Otherwise the function will be called on import 😄
There was a problem hiding this comment.
My guess would be that you will also need to therefore change schema-object-factory.
Let me know if I can help
There was a problem hiding this comment.
Thank you for pointing it out @slukes. I'll let you know if I need any help changing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2786
What is the new behavior?
Allows enum to have functions that return array of Records ( string or num )
Does this PR introduce a breaking change?
Other information