Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): fix enum array on model properties #810

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Jun 17, 2020

fix #808

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #808

What is the new behavior?

@ApiProperty({ enum: EnumType, enumName: 'EnumType', isArray: true }) should produce the correct schema

{
   "type": "array",
   "items": {
       "$ref$": "#/components/schemas/EnumType"
    }
}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 7a208fd into nestjs:master Jun 18, 2020
@kamilmysliwiec
Copy link
Member

Thank you ❤️

@nartc nartc deleted the bugfix/fix-array-enum-on-model branch June 18, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array of enums not working as expected
2 participants