feat(): upgrade to v8

BREAKING CHANGE: Upgrade to NestJS v8.x.x
nestjs · Aug 27, 2021 · ba6eee0 · ba6eee0
1 parent 6dd469a
commit ba6eee0
Show file tree

Hide file tree

Showing 12 changed files with 3,525 additions and 9,500 deletions.
diff --git a/lib/health-check/health-check.service.ts b/lib/health-check/health-check.service.ts
@@ -15,7 +15,7 @@ import { HealthCheckResult } from './health-check-result.interface';
 export class HealthCheckService {
   constructor(private healthCheckExecutor: HealthCheckExecutor) {}
 
-  private readonly logger = new Logger(HealthCheckService.name, true);
+  private readonly logger = new Logger(HealthCheckService.name);
 
   /**
    * Logs an error message of terminus

diff --git a/lib/health-indicator/database/typeorm.health.ts b/lib/health-indicator/database/typeorm.health.ts
@@ -73,7 +73,7 @@ export class TypeOrmHealthIndicator extends HealthIndicator {
   }
 
   private async checkMongoDBConnection(connection: any) {
-    return new Promise((resolve, reject) => {
+    return new Promise<void>((resolve, reject) => {
       const driver = connection.driver as any;
       // Hacky workaround which uses the native MongoClient
       driver.mongodb.MongoClient.connect(

diff --git a/lib/health-indicator/dns/dns.health.ts b/lib/health-indicator/dns/dns.health.ts
@@ -1,8 +1,10 @@
-import { Injectable, HttpService, Scope } from '@nestjs/common';
+import { Injectable, Scope } from '@nestjs/common';
+import { HttpService } from '@nestjs/axios';
 import { AxiosResponse, AxiosRequestConfig, AxiosError } from 'axios';
 import { HealthIndicator, HealthIndicatorResult } from '../';
 import { HealthCheckError } from '../../health-check/health-check.error';
 import * as deprecate from 'deprecate';
+import { lastValueFrom } from 'rxjs';
 
 /**
  * The DNSHealthIndicator contains health indicators
@@ -100,11 +102,12 @@ export class DNSHealthIndicator extends HealthIndicator {
     options: AxiosRequestConfig = {},
   ): Promise<HealthIndicatorResult> {
     try {
-      const response = await this.httpService
-        .request({ url: url.toString(), ...options })
-        .toPromise();
+      const response = lastValueFrom(
+        this.httpService
+            .request({ url: url.toString(), ...options }),
+      );
 
-      const isHealthy = await callback(response);
+      const isHealthy = await callback(await response);
 
       if (!isHealthy) {
         throw new HealthCheckError(

diff --git a/lib/health-indicator/http/http.health.spec.ts b/lib/health-indicator/http/http.health.spec.ts
@@ -1,6 +1,6 @@
 import { Test } from '@nestjs/testing';
 import { HealthCheckError } from '../../health-check/health-check.error';
-import { HttpService } from '@nestjs/common';
+import { HttpService } from '@nestjs/axios';
 import { EMPTY, of, throwError } from 'rxjs';
 import { AxiosResponse, AxiosRequestConfig, AxiosError } from 'axios';
 import { HttpHealthIndicator } from './http.health';

diff --git a/lib/health-indicator/http/http.health.ts b/lib/health-indicator/http/http.health.ts
@@ -1,7 +1,9 @@
-import { Injectable, HttpService } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
+import { HttpService } from '@nestjs/axios';
 import { AxiosResponse, AxiosRequestConfig, AxiosError } from 'axios';
 import { HealthIndicator, HealthIndicatorResult } from '..';
 import { HealthCheckError } from '../../health-check/health-check.error';
+import { lastValueFrom } from 'rxjs';
 
 /**
  * The HTTPHealthIndicator contains health indicators
@@ -94,11 +96,11 @@ export class HttpHealthIndicator extends HealthIndicator {
     const httpService = httpClient || this.httpService;
 
     try {
-      const response = await httpService
+      const response = lastValueFrom(httpService
         .request({ url: url.toString(), ...options })
-        .toPromise();
+      );
 
-      const isHealthy = await callback(response);
+      const isHealthy = await callback(await response);
 
       if (!isHealthy) {
         throw new HealthCheckError(

diff --git a/lib/health-indicator/memory/memory.health.ts b/lib/health-indicator/memory/memory.health.ts
@@ -1,5 +1,4 @@
 import { Injectable } from '@nestjs/common';
-
 import { HealthIndicator, HealthIndicatorResult } from '../';
 import { STORAGE_EXCEEDED } from '../../errors/messages.constant';
 import { StorageExceededError } from '../../errors';

diff --git a/lib/terminus-bootstrap.service.ts b/lib/terminus-bootstrap.service.ts
@@ -31,7 +31,7 @@ export class TerminusBootstrapService implements OnApplicationBootstrap {
   /**
    * The NestJS logger
    */
-  private readonly logger = new Logger(TerminusBootstrapService.name, true);
+  private readonly logger = new Logger(TerminusBootstrapService.name);
 
   constructor(
     @Inject(TERMINUS_MODULE_OPTIONS)

diff --git a/lib/terminus-core.module.ts b/lib/terminus-core.module.ts
@@ -3,9 +3,9 @@ import {
   Global,
   Module,
   Provider,
-  HttpModule,
   Type,
 } from '@nestjs/common';
+import { HttpModule } from '@nestjs/axios';
 import {
   TerminusModuleOptions,
   TerminusModuleAsyncOptions,

diff --git a/lib/terminus-lib.provider.ts b/lib/terminus-lib.provider.ts
@@ -1,5 +1,4 @@
 import { TERMINUS_LIB } from './terminus.constants';
-import { Provider } from '@nestjs/common';
 import { checkPackages } from './utils';
 
 /**

diff --git a/lib/terminus.module.ts b/lib/terminus.module.ts
@@ -1,4 +1,5 @@
-import { DynamicModule, Module, HttpModule } from '@nestjs/common';
+import { DynamicModule, Module } from '@nestjs/common';
+import { HttpModule } from '@nestjs/axios';
 import {
   TerminusModuleOptions,
   TerminusModuleAsyncOptions,