Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Pagination): Fixed pageCount number #180

Merged
merged 1 commit into from Jul 20, 2019
Merged

fix(Pagination): Fixed pageCount number #180

merged 1 commit into from Jul 20, 2019

Conversation

bashleigh
Copy link
Collaborator

@bashleigh bashleigh commented Jul 19, 2019 •
edited

With a total of 41 items, the pageCount should be 5 whereas it was returning 4

179

Wanted to add a test but wasn't sure how? Existing tests still pass

fix(Pagination): Fixed pageCount number
6886fc9 
With a total of 41 items, the pageCount should be 5 whereas it was returning 4

179
@bashleigh bashleigh self-assigned this Jul 19, 2019
@bashleigh bashleigh marked this pull request as ready for review July 20, 2019 07:16
@bashleigh bashleigh merged commit 06b5d46 into master Jul 20, 2019
@bashleigh bashleigh deleted the fix/179-pagination branch July 20, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelyali michaelyali michaelyali approved these changes

Assignees

@bashleigh bashleigh

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bashleigh @michaelyali