Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crud-objection): add Objection.js based CRUD package #211

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rychkog
Copy link

@rychkog rychkog commented Aug 12, 2019

No description provided.

@rychkog
Copy link
Author

rychkog commented Aug 14, 2019

Coveralls definitely doesn't want this PR to become green :)
It either has this 405 Not Allowed which means that amount of coverage uploads reached its limit

or Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true} which I believe is connected to lemurheavy/coveralls-public#632, because coveralls doesn't recognize crud-objection

@michaelyali michaelyali added the v5 label Dec 12, 2019
@bestori
Copy link
Contributor

bestori commented Jun 11, 2020

@rychkog just fix the conflicts, and let's get on with it! :)

@rychkog
Copy link
Author

rychkog commented Jun 12, 2020

@rychkog just fix the conflicts, and let's get on with it! :)

@bestori thanks, finally! :)) Sure will update it as soon as possible

@mdartic
Copy link

mdartic commented Jun 26, 2020

@rychkog I'm curious about this PR, do you succeed in allowing nestjsx/crud filtering JSON data ?
Like it's documented here https://vincit.github.io/objection.js/recipes/json-queries.html
If not, do you think it could be possible to extend this PR ?

@rychkog
Copy link
Author

rychkog commented Jun 27, 2020

@rychkog I'm curious about this PR, do you succeed in allowing nestjsx/crud filtering JSON data ?
Like it's documented here https://vincit.github.io/objection.js/recipes/json-queries.html
If not, do you think it could be possible to extend this PR ?

@mdartic The plan is to get it merged in the form that supports all the general features provided by the nextjsx/crud.
I've made this PR in August 2019 and there are lots of changes that happened to the nextjsx/crud since then (including new search query approach), so I need to change lots of stuff in this PR and bring those changes into it first (this is in progress at the moment :)).

Once this is done I can start working on features like JSON data filtering in crud-objection, cause I'm also a big fan of Postgres and use it on an everyday basis :).

So answering your original question - don't think there will be a support for that in this PR (cause it will take time and with every delay, this PR potentially diverges from the main branch ), BUT I do definitely plan to work on that in subsequent PRs :)

@rychkog rychkog force-pushed the feature/crud-objection branch 2 times, most recently from 8913958 to a34eded Compare July 5, 2020 13:36
@rewiko
Copy link
Collaborator

rewiko commented Nov 28, 2021

I am trying to help and have forked this repo (can't reach the owner of this repo and do not have the credential for the npm repo).

See #710 (comment)

We can hopefully merge it via rewiko#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants