Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/always paginate #344

Merged
merged 5 commits into from
Dec 10, 2019
Merged

Feature/always paginate #344

merged 5 commits into from
Dec 10, 2019

Conversation

michaelyali
Copy link
Member

No description provided.

jdguzman and others added 5 commits October 9, 2019 19:01
…ation default

BREAKING CHANGE: getManyBase now returns a paginated result by default unless opted out by setting
`alwaysPaginate: false`

re #213
…n-with-fallback

feat(crud-typeorm): Adds alwaysPaginate global option and makes pagin…
@michaelyali
Copy link
Member Author

@jdguzman in order not to break existing implementation, alwaysPaginate will be false by default. So users could enable it globally or in the controller's options

@michaelyali michaelyali merged commit d428123 into master Dec 10, 2019
@michaelyali michaelyali deleted the feature/always-paginate branch December 12, 2019 06:47
@hakimio
Copy link

hakimio commented Dec 17, 2019

@zMotivat0r can you add alwaysPaginate to global options (CrudConfigService.load({})) as well?

@michaelyali
Copy link
Member Author

@hakimio

query: {
alwaysPaginate: false,
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants