New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: filter conditions missing the sql LOWER() function #395

Merged

michaelyali merged 1 commit into nestjsx:master from steeu:master

Apr 12, 2020

Contributor

steeu commented Jan 21, 2020

The filter conditions $startL, $endsL, $contL, $excl where missing the sql LOWER() function to work correctly.

The fix was tested on an oracle DB. Now the SQL queries are executed correctly.


          fix filter conditions with LOWER()

765fc9a

fixed conditions $startL, $endsL, $contL, $excl

Pranen approved these changes

View reviewed changes

Pranen left a comment

Just checked the code. The ${likeOperator} is for all dbs but postgres always LIKE.
That changes looks fine to me.

michaelyali merged commit 2783803 into nestjsx:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment